Mars-aliens
Mars-aliens
The failure in the Benchmarks workflow appears unrelated to this PR. This change only touches documentation, so no benchmark CSV files are produced, and the benchmark_results_*.csv glob resolves to an...
You're right — the change in github/workflows/ci.yml isn’t needed for this PR. It was added while testing some benchmark issues but isn’t required anymore. I’ll remove it in the next...
> I think you ended up changing the line endings in some files. Please revert that, or just replace them with standard Unix line endings everywhere. Hi! Following up on...
@scoder Hi! Just following up on this PR since it has been a while. Please let me know if there’s anything I should improve or adjust. Thanks!
@matusvalo Hi, just a friendly reminder on this PR since it's been a while. Let me know if there’s anything I should update or revise. Appreciate your review!
> There's definitely still a bunch of files which are identical except for line ending whitespace changes (your editor has substituted `/n` for `/r/n`) which should be undone. That might...
> > > There's definitely still a bunch of files which are identical except for line ending whitespace changes (your editor has substituted `/n` for `/r/n`) which should be undone....
> Mostly fine now, but I also had a few comments. Once the remaining ones are resolved, I think this'll be done. Thanks for the detailed feedback! I've incorporated the...