MarkoNV

Results 10 comments of MarkoNV

I agree, rolling back is not handling Exception and it should be rethrown so other code could handle it. Alternative solution is to handle Exceptions inside the closure. If Exception...

@WinterSilence maybe it would be more appropriate to handle this by `load()` method. `$_POST` doesn't have any mean to send empty array, so to be able to set variable to...

@WinterSilence I think we had disagreement about cause of #19446. Your view is that setting `$options['unselect'] = '';` is issue. But I disagree, I have to agree with @rob006 here....

@WinterSilence > nope, in this case the old version throws an exception Example from bug report throws exception because property doesn't accepts all possible values from user. In my two...

@easydowork it can be useful for requests which don't populate $_POST, but: - it should be configurable and disabled by default - it shouldn't be redundant (`getBodyParams()` returns raw +...

Can confirm, both PHP 7.4 and PHP 8.1 on Windows.

@rafdulaf workaraound for your case would be (if I understood correctly): `valid_elements: "#p,span[!annotation]"` That would be even more appropriate because this requires that annotation attribute must exists (it can be...

Sorry, I noticed that I didn't update issue number in branch name. Is it issue?

@samdark After #18540, change of `authKey` invalidates sessions. But documentation says calling `yii\web\User::switchIdentity()` or `yii\web\User::login()` will prevent logout of current session, which is done for user experience (only session that...

@samdark can you check failing tests? My commit passed tests, only after merging master branch to my branch errors occurred. Also, I see that many other pull requests have failed...