Mark Callow

Results 429 comments of Mark Callow

The repo in question is https://github.com/KhronosGroup/KTX-Software in the default branch. The subrepo in question is `lib/astc-encoder`. `HEAD~1` is the last pull. The parent commit shown in `.gitrepo` is 90c01d4 which...

> Any suggestions for other things to try? After every `git subrepo pull` now I check the parent commit in the `.gitrepo` file. When it hasn't been updated, which is...

> I'll play around a bit and see if I can find a way to reproduce this. Fantastic! I hope you are successful.

@elasticdog thank you for your thorough investigation. Hopefully there is enough here for the repo maintainer to figure out where the code is wrong and fix it.

Not sure why you need that fix for gl3loadtests. It's been building on Windows for a very long time. You still need to fix `.reuse/dep5` for some of the moved...

reuse is still failing related to `external/fmt`. I've reviewed the basisu-related changes. They look good. More tomorrow.

> @MarkCallow I fixed the Reuse issues. CI is now failing on the Emscripten bindings, but I believe it is unrelated to the changes here and is a result of...

The changes to Emscripten are apparently intentional. However the fix they suggested makes zero difference. Finding a fix will take more time.

Here is a patch for the Emscripten 3.1.60 issue. Please add it to this PR. [ktx_wrapper.patch](https://github.com/KhronosGroup/KTX-Software/files/15410690/ktx_wrapper.patch)

@MathiasMagnus thank you for this well organized piece of work.