MarioLeandro

Results 9 comments of MarioLeandro

Hey @pat270 about: > I also noticed some other issues with this component. > > The checkboxes should have aria-labelledby={THE_ID_OF_COMPONENT_TEXT}. > The checkbox and component-text both have the same id....

Hey @pat270. I realized that in StyleBooks we need to wrap the Checkbox to avoid TypeScript errors with required properties, and this causes the component to lose its `displayName` property,...

> I'm seeing issues in Treeview with checkboxes. It's selecting / unselecting everything. Hi @pat270. I don't think that's an issue. I believe you're using old examples from the stylebook...

Hi @pat270, I understand now. I just submitted a change that fixes the bug you mentioned. For ``` const OptionalCheckbox = Object.assign( (props: any) => , { displayName: 'ClayCheckbox', }...

Hey @pat270, I believe this pattern is being used because `` requires the `checked` property, and since the Treeview overrides it in this case, I don't think it would make...

> @MarioLeandro directly replacing seems to be working for me without issue, see my commit at #6217. Changed it @pat270. I was using VSCode TS version, started using the workspace...

Hey @ethib137 found another way to validate the toggle and remove that questionable code. However, other points are using `@ts-ignore`, and from what I've seen, most of them relate to...

Hi @ethib137 created some tests to ensure the expansion. Regarding the arrow down behavior, i forgot to mention, but Patrick sent a [comment](https://github.com/liferay/clay/pull/6214#discussion_r2579097015) Where it said the button represented by...

Hi @pat270! Just reduced the number of commits, i think it's fine now. Also i think that we will need to update the portal, mainly due to changes in the...