MarinaAForgeFlow comments

Results 5 comments of


                                            MarinaAForgeFlow

[16.0][FIX] account_journal_restrict_mode: Ensure that the secure sequence is always created.

LGTM

[16.0][FIX] intrastat_product: skip invoice with non EU country

Hi @joao-p-marques. I see that you worked on the intrastat_product migration to v16 and that you refactored the code for the method "_get_partner_country". In this PR I have added a...

[16.0][FIX] intrastat_product: skip invoice with non EU country

Hi @alexis-via , is there any possibility that we can get this PR re-opened?

[16.0][IMP] intrastat_product: erase computed lines when the declaration scope changes

Hi @pedrobaeza, could you explain why do you think that it should depend on the mode? What I think is that, if the user changes, for example, the month of...

[16.0][IMP] intrastat_product: erase computed lines when the declaration scope changes

Oh I did not think about this use of the report. Then this change may not be needed at all, as the user could want to aggregate arrivals and dispatches...