gpu-allocator icon indicating copy to clipboard operation
gpu-allocator copied to clipboard

Add `no_std` support

Open CrazyboyQCD opened this issue 10 months ago • 4 comments

CrazyboyQCD avatar Feb 12 '25 08:02 CrazyboyQCD

Almost forgot to mention: can you please drop the chore: prefix from your commit messages? It's not used by this project and does not have any meaning in this context.

a routine task, especially a household one.

I don't think a one-off no_std conversion in a crate is considered a "routine task" :slightly_smiling_face:

MarijnS95 avatar Feb 12 '25 09:02 MarijnS95

msrv is required to bump to either 1.75+(if we switch from thiserror to derive_more) or 1.81+ to get CI work.

CrazyboyQCD avatar Feb 13 '25 02:02 CrazyboyQCD

I'm thinking of raising the MSRV unconditionally, that seems a lot less tricky to users than pretending it's 1.71, as long as they turn on the "std" feature 😅

MarijnS95 avatar Jun 12 '25 20:06 MarijnS95

I've squashed everything down into a single commit because our branch protection requires every individual commit to have been signed. Even if squash-merging will squash and resign the entire PR with GitHub's "web workflow" signature anyway 🤷

Since I contributed to and approve the final result, it makes sense for me to sign such a final result (but not individual commits) :)

MarijnS95 avatar Jun 12 '25 20:06 MarijnS95

Should we go ahead and merge this?

Jasper-Bekkers avatar Jul 14 '25 08:07 Jasper-Bekkers