Marie Sacksick

Results 12 comments of Marie Sacksick

I considered tackling this issue before the sprint, but it looks like it's all done and that it can be closed :)!

Hello @rcap107! Shouldn't this be something defined in scikit-learn [class](https://github.com/scikit-learn/scikit-learn/blob/main/sklearn/utils/_bunch.py) itself?

Exemples of cross-references to add: - [x] in [cross_validate](https://skrub-data.org/dev/reference/generated/skrub.cross_validate.html#skrub.cross_validate), - [x] in [describe_steps](https://skrub-data.org/dev/reference/generated/skrub.Expr.skb.describe_steps.html#skrub.Expr.skb.describe_steps), add "See Also" for draw_graph and full_report. - [x] in [drop](https://skrub-data.org/dev/reference/generated/skrub.Expr.skb.drop.html#skrub.Expr.skb.drop) add a link to [selectors](https://skrub-data.org/dev/reference/generated/skrub.selectors.Selector.html) -...

To join Section Navigation in submenus in API page, one has to modify [this page](https://github.com/skrub-data/skrub/blob/main/doc/reference/index.rst). Example in [skore](https://github.com/probabl-ai/skore/tree/skore/0.9.1/sphinx/reference).

Some precisions to help for a coming sprint. ## TODO - [ ] change imports, with [this line](https://github.com/skrub-data/skrub/blob/d085d77dfe256e26c635cb17968ebc5cc04d1a5e/skrub/__init__.py#L45) and [this line](https://github.com/skrub-data/skrub/blob/d085d77dfe256e26c635cb17968ebc5cc04d1a5e/skrub/__init__.py#L96). - [ ] adapt all the tests and doctests...

Agree with you that it should be possible to turn off this automatic transformation of string to float for some columns in the dataframe. The Cleaner and TableVectorizer apply to...

Hi @mithilP007 :)! Could you please remove the changes about `# noqa: F401` in scikit-learn compat file? It looks like it's breaking the CI, plus it's not related to the...

Do you need input from us or is it more a question for @GaelVaroquaux and @rcap107?

I never used them. If I had to do what they do in their examples, I would use an apply I think, and the lib datetime.