Maria José Solano
Maria José Solano
@justinmk @ribru17 related to improving this API, thoughts on moving the text configuration from `vim.diagnostic.config { signs = { text = ... } }` to a new config field different...
Should we add a new test? Also, for git history purposes a more descriptive PR title/commit message is appreciated :)
@saecki just so that I better understand your workflow: Where exactly do you have that code snippet? Is it part of your LSP `on_attach` function?
@Saghen sorry for not providing a complete repro! But @geril2207 explained the issue perfectly above. Let me know if you would like me to provide more information.
@sagg0t no need to mark this as breaking. The entire feature is new and so we're allowed to break stuff at this stage.
@lewis6991 I'm not done ofc but I would appreciate a quick look before I continue to ensure that this matches what you had in mind.
@lewis6991 @mfussenegger is it okay if I add the cancellation logic in a later PR?
> Why? There's no rush for this. You can add it as a separate commit if that's better. It feels like there's still some pending design discussions around it and...
> What pending decisions though? I'm not sure if there are any ([ref](https://github.com/neovim/neovim/pull/34506#issuecomment-2973298872)), and if there are, that's then the important work that needs doing. It would help if something...
@lewis6991 when you get a minute could I please get a review here 😁?