Maria José Solano

Also refer to https://github.com/neovim/neovim/blob/2e0158650a3be0bcfdb6a2f28c6d7266c525e94a/CONTRIBUTING.md#commit-messages on how to write commit messages (and fix the failing CI check).

@justinmk Do you think that we should document the preferred terminology of some of these concepts in our maintenance docs?

Sounds like a reasonable request to me. Tagging @lewis6991 @gpanders @mfussenegger and @justinmk for the bikeshedding discussion.

Summarizing some of the discussion I had on Matrix with @lewis6991 and @clason about the implementation details of this: - We would need a new `vim.lsp.workspace_diagnostics()` function that returns all...

> It shouldn't go in `vim.diagnostic` as it just doesn't belong there. Vim.diagnostic does not make LSP requests This feels like an implementation detail though. From a public API standpoint,...

Fair enough. Thank you @gpanders and @lewis6991 for explaining. I apologize if I'm being slow in understanding the design decisions here, but as someone who lacks some of the historical...

> After looking at what's already in `vim.lsp.buf`, I agree, we can just add a new function there for now. We can bikeshed a new home/namespace later. Why not just...

Okay then. I’ll add the new function to (the poorly named) `vim.lsp.buf`.

@brianhuster Or anyone else following this thread: Do you have a (preferably easy to set up) language server that supports workspace diagnostics that I can use to test https://github.com/neovim/neovim/pull/34262?

> I think [basedpyright](https://github.com/DetachHead/basedpyright) (an LS for Python) supports workspace diagnostic. The config could look like this (assuming you also use [nvim-lspconfig](https://github.com/neovim/nvim-lspconfig)) > > ---@type vim.lsp.Config > vim.lsp.config.basedpyright = {...