Maria

Results 181 comments of Maria

Thanks for documenting this feature! I followed the guide and dont have the vcs capability in the Ansible feature. is there something else need doing (other than the steps in...

added `white-space: pre-line;` so that the comment view will show newlines

By default, React DOM escapes any values embedded in JSX before rendering them. (https://legacy.reactjs.org/docs/introducing-jsx.html#jsx-prevents-injection-attacks) Is there other risk I didnt see?

> Do we somewhere have a XSS tests which tries to inject certain JS stuff in textarea / other user-defined input fields and then tries to find out if the...

rebased and katello test failures look unrelated

It was noticed when reviewing a pr in foreman_ansible, to test I added hasHelpPage in webpack/assets/javascripts/react_app/routes/Models/ModelsPage/index.js

The code is fine, but can you give an example of where its needed?

not sure how to recreate the bug, and the pr needs splitting but the .erb and .js code looks ok

It seems to work as expected in ui and api, the code makes sense but I think we need a Ruby person to verify it, @adamruzicka ?

Also opened https://github.com/theforeman/foreman-packaging/pull/12092 https://github.com/theforeman/foreman-infra/pull/2262