Maria

Results 181 comments of Maria

I have some tests failing also on master branch btw, @Ron-Lavi Can you open a separate pr for those tests?

@ekohl jquery is in https://github.com/theforeman/foreman-js/pull/479

About the search, I think in this bugzilla we decided that foreman search doesnt search on clear: https://bugzilla.redhat.com/show_bug.cgi?id=1997660

Thanks @jeremylenz! Changed so when a user clicks on the X icon in the search it searches for ""

Thanks @jeremylenz, did the changes you asked

`invalid session id` error in the tests is not related to this pr

If webpack 5 is not reverted I dont see a reason for this to not be merged really soon. Looking at the test failures now.

@ekohl do we need npm8 for EL9?

> When I tried I could actually install it without forcing legacy peer dependencies. Are you sure it's still needed? did you run `npm test` or compile webpack? for me...

Should we just do the jump and update to node 18 instead?