MarcusGrass

Results 26 comments of MarcusGrass

> Hi Thanks for this PR. > > Do you mind splitting the feature gates from the dependencies update in separate PRs ? > > It's much easier for me...

I think it's the below code, since the scroll is a ButtonPressEvent on X11, and since winit uses XI_RAW I can't grab it. ```Rust ffi::XI_RawButtonPress | ffi::XI_RawButtonRelease => { let...

> Alacritty isn't using any `DeviceEvent`'s in fact it'll opt out from them entirely in the next release. So I do think that this bug in your wm, since it's...

I made a more legitimate PR with this change here https://github.com/rust-windowing/winit/pull/2362. XI_ButtonPress is disregarded completely in favor of ButtonPress, however, XI_Motion is still used but if the device is targeting...

Can't implement Copy if Vec should allow drop. https://stackoverflow.com/questions/51704063/why-does-rust-not-allow-the-copy-and-drop-traits-on-one-type You can't conditionally implement Drop either so the choice is to implement Copy conditionally on copy types or respect Drop. Respecting...

Having the same issue, scrolling works "sometimes" then I figured out that it's working if you hit the padding between the buttons

> Hello, someone who doesn't work on rustfmt but has been thinking about it recently here. I feel like cargo-fmt is probably the place to put the parallelism. [I made...

I've been looking a bit closer at the code. `cargo fmt` supplies crate roots, those are then parsed by `rustfmt` and the files are formatted single-threaded. Which in practice means...

> That was a 10 minute implementation. The 64 file chuck was made up. It can obviously be improved, I just wanted to see if it worked as I thought...

Just for posterity, I did dig into the code more and think I understand some of the fundamental problems with implementing multithreading in Rust internals, I heard a bit about...