Marcus Denker

Here is a list of issues related to Symbols and the SymbolTable - [x] #compactSymbolTable leads to hash collisions #11319 - [ ] Speed up Symbol finding #12940 - [...

failing tests not related

it looks like colorTransform is never set to anything, it is always nil. The setter is only called from FormCanvas>>#ensuredEngine, which is the only access of colorTransform in FormCanvas

I checked: yes, you are right! I think in the past, #allInstancesDo: was iterating using #nextObject, so using it was avoiding to allocate the bug array... but now we have...

#instancesSizeInMemory is similar

Looking at this again... #allInstancesDo: does have a special case when memory is too low to allocate the array: ``` "allInstancesOrNil can fail because memory is low. If so, fall...

instanceCount uses allInstancesDo: so that if memory is not there to allocate the big array, it uses the fallback. If instanceCount would use allInstances, it would just fail.

``` allInstancesDo: aBlock "Evaluate aBlock with each of the current instances of the receiver." | instances inst next | instances := self allInstancesOrNil. instances ifNotNil: [instances do: aBlock. ^self]. "allInstancesOrNil...

We see this for some PRs on the CI. Merging the PR then seems to not lead to any problems for the build, though. example: https://github.com/pharo-project/pharo/pull/11662 failing tests on win...

Could be related to https://github.com/pharo-project/pharo/issues/11665