pharo Cleanup on The package TestRunner

Cleanup on The package TestRunner

Open aboubacardiawara opened this issue 3 years ago • 1 comments

trafficstars

The cleanup concerns the following point:

Aug 08 '22 09:08 aboubacardiawara

failing tests not related

Aug 17 '22 09:08 MarcusDenker

I like it, but I would do two steps :

integrate
remove old TestRunner
rename NewTestRunner, NewCommandLineRunner classes to just TestRunner and CommandLineRunner.

Oct 24 '22 08:10 estebanlm

also: CommandLineRunner needs to be renamed to CommandLineTestRunner and we need an UI

and now that I see, names are messed up since TestRunner is the current name of the UI (and your NewTestRunner is an executor).

Oct 24 '22 09:10 estebanlm

This is cool that you review this.

Oct 24 '22 13:10 Ducasse

Thanks for your review. I will apply your suggested changes.

Oct 24 '22 23:10 aboubacardiawara

I'm trying to find the code but I do not find it in the image in the latest P11.

Dec 10 '22 14:12 Ducasse

I'm trying to find the code but I do not find it in the image in the latest P11.

It can be found after cloning the Pharo project again in a loaded image. Before that I couldn't find it either

Dec 10 '22 15:12 aboubacardiawara

Thanks!

Dec 10 '22 17:12 Ducasse