Marcus Denker comments

Results 295 comments of


                                            Marcus Denker

Port to pharo13 bugfix issue 16702: Trait class side methods sometimes not installed on user classes.

No, the same tests fail on Pharo12, too. There are now three PRs for this fix, maybe we should close all but Pharo13 and backport when we now that it...

Port to pharo13 bugfix issue 16702: Trait class side methods sometimes not installed on user classes.

The random tests are not related,added an issue: https://github.com/pharo-project/pharo/issues/16763 But there are tests failing like TraitFileOutTest and more

Cannot rename a class instance var: RBRenameInstanceVariableRefactoring can not deal with class instance variables

I think the Code just can not yet handle class instance variables (aka class side slots). It uses RBRenameInstanceVariableRefactoring, but the condisoon checking there uses the *name* of the class:...

Pharo 11 Backport of Fix + Tests for issue #16702 : Trait class side…

Build fails: ``` MetacelloNotification: Fetched -> BeautifulComments-tonel.1 --- github://pillar-markup/BeautifulComments:v1.0.0/src --- github://pillar-markup/BeautifulComments:v1.0.0/src MetacelloNotification: Project: NewToolsDocumentBrowser baseline MetacelloNotification: ...RETRY->BaselineOfMicrodown MetacelloNotification: ...RETRY->BaselineOfMicrodown FileDoesNotExistException: '/tmp/github--pillarmarkupMicrodownintegration219820944924360708700770148181567648417.zip' File>>openForWrite: File>>openForRead File>>readStream FileHandle>>binaryReadStream FileSystem>>binaryReadStreamOn: FileReference>>binaryReadStream ZipArchive>>readFrom: ``` This...

Walkback: #name was sent to nil on MethodRecategorized announcement when filing in code

I think the FileOut files out categories wrongly: If you look at your fileout, the preamble has the protocol wrongly as "Protocol (*TimTools) - 1 selector(s)" ``` !StRewriterDemoRules class methodsFor:...

Walkback: #name was sent to nil on MethodRecategorized announcement when filing in code

One place where this might happen is ChangeRecord>>#fileOutOn:

Slot template definition can be confusing to read (instance vs. class side methods, keyword chaining vs. unary chaining, ...)

My main motivation was to avoid having to put () everywhere. I will check the suggestions. We need to do a pass anyway, as we have to add some way...

Slot template definition can be confusing to read (instance vs. class side methods, keyword chaining vs. unary chaining, ...)

Not yet, too much other things in June/July and then there was holidays...

Slot template definition can be confusing to read (instance vs. class side methods, keyword chaining vs. unary chaining, ...)

UndefinedObject reportWin32GFXDetails:

These are all just for windows: ``` self isWindows ifTrue: [ { (#'OS Details' -> #reportWin32OSDetails:). (#'VM Configuration' -> #reportWin32VMConfig:). (#'Hardware Details' -> #reportWin32HardwareDetails:). (#'GFX Hardware Details' -> #reportWin32GFXDetails:). }...