Port to pharo13 bugfix issue 16702: Trait class side methods sometimes not installed on user classes.

[bouraqadi]

Bug fix initially implemented for P12

[MarcusDenker]

Lots of tests are failing:

 Unix64.Collections.Sequenceable.Tests.ArrayTest.testShuffleBy	1.2 sec	1
 Unix64.Collections.Support.Tests.CollectionTest.testAtRandomWeighting	10 sec	1
 Unix64.Collections.Support.Tests.CollectionTest.testAtRandomWeightingMultiple	10 sec	1
 Unix64.Fuel.Core.Tests.FLCreateClassSerializationTest.testCreateWithTraitOnClassSide	10 sec	1
 Unix64.Fuel.Core.Tests.FLCreateTraitSerializationTest.testCreateWithTraitOnClassSide	10 sec	1
 Unix64.Kernel.Extended.Tests.UnicodeTest.testRNG	8.7 sec	1
 Unix64.Network.Tests.UUIDPrimitivesTest.testCreationNodeBased	9 sec	1
 Unix64.PharoDocComment.Tests.CommentTestCase.nil	5 sec	1
 Unix64.PharoDocComment.Tests.CommentTestCase.nil	6.7 sec	1
 Unix64.PharoDocComment.Tests.CommentTestCase.nil	7.3 sec	1
 Unix64.RTree.Tests.RTreeTest.testRemoveLeaf1	10 sec	1
 Unix64.Random.Tests.RandomTest.testDistribution	8.8 sec	1
 Unix64.Random.Tests.RandomTest.testPrimitiveRandomGeneration1	8.7 sec	1
 Unix64.Random.Tests.RandomTest.testPrimitiveRandomGeneration2	9 sec	1
 Unix64.Random.Tests.RandomTest.testPrimitiveRandomGeneration3	8.6 sec	1
 Unix64.Roassal.Global.Tests.RSForceBasedLayoutTest.testAddNodesAndEdges	0.49 sec	1
 Unix64.Roassal.Global.Tests.RSRTreeTest.testRemoveLeaf1	0.67 sec	1
 Unix64.Slot.Tests.SlotTraitsTest.testClassWithClassTrait	1.6 sec	1
 Unix64.Slot.Tests.SlotTraitsTest.testModifyClassTraitComposition	1.5 sec	1
 Unix64.Slot.Tests.SlotTraitsTest.testRemoveClassTrait	1.8 sec	1
 Unix64.Slot.Tests.SlotTraitsTest.testTraitUsersAfterClassReshape	1.6 sec	1
 Unix64.Slot.Tests.SlotTraitsTest.testTraitUsersAfterMetaclassReshape	1.5 sec	1
 Unix64.Traits.Tests.TraitFileOutTest.testFileOutCategory	9.1 sec	1
 Unix64.Traits.Tests.TraitFileOutTest.testFileOutTrait	9 sec	1
 Unix64.Traits.Tests.TraitFileOutTest.testRecompiling	8.8 sec	1
 Unix64.Traits.Tests.TraitFileOutTest.testRemovingMethods

[Ducasse]

This is strange. Are you sure that we got a fix in P12 that is not in P13

[MarcusDenker]

No, the same tests fail on Pharo12, too.

There are now three PRs for this fix, maybe we should close all but Pharo13 and backport when we now that it works

[MarcusDenker]

The random tests are not related,added an issue: https://github.com/pharo-project/pharo/issues/16763

But there are tests failing like TraitFileOutTest and more

[bouraqadi]

I understand, the issues were not related to this PR. Can you merge it please?

[jecisc]

I restarted the CI