MaoShizhong

Results 111 comments of MaoShizhong

From my own experiences across the channels, even some of the most helpful messages don't get a great deal of bookmarks. Generally stuff that gets bookmarked are things sent during...

Going to close this as it seems we're not intending to implement this for the above reasons.

I presume these are the lines that would need changing to make the request body serialisation match the documentation and query param serialisation for the [client version](https://github.com/ladjs/superagent/blob/1c8338b2e0a3b8f604d08acc7f3cbe305be1e571/src/client.js#L195) and the [Node...

Looks like asserting throws with a POJO was breaking backwards compatibility with the action runs. This change should hopefully be backwards compatible with the versions now.

Could I get some guidance on exactly what needs fixing here for the action runs? I'm a little confused as to why some tests that passed last run now suddenly...

@wesleytodd Just to clarify, what exactly do you mean by "adding `.code` to these"?

@wesleytodd Apologies, I'm unfamiliar with these practices currently (for now) so I'm getting the gist but not 100% certain exactly what sort of change you would like me to do...

Thank you for the confirmation and insight! TIL I'll get a fresh PR with a `.code` changes up shortly, then changing the `.message` can be reserved for a major release...

That's a very good point I've not previously considered (haven't really worked on libraries much, especially something as fundamentally used as this). Would you still like me to amend the...

Excellent - appreciate the guidance on this.