MaoShizhong

Results 111 comments of MaoShizhong

@rmn-k Thank you for opening this issue. Just above the assignment section, there's a section labelled `Tips on when to commit`, which is part of the instructions for setting up...

Closing as it no further response nor further action required.

@T0nci I think this a little extra clarity wouldn't hurt, given it seems to be clearly intended as an optional alternative and the content does cover the same concepts as...

@T0nci Something like > As an optional alternative, in case you prefer video lessons ... should probably suffice.

Oops, wrong button - *you're* the one assigned now, not me :stuck_out_tongue_closed_eyes:

@T0nci That's part of the [layout style guide](https://github.com/TheOdinProject/curriculum/blob/main/LAYOUT_STYLE_GUIDE.md#lazy-numbering) where we use lazy numbering to make it easier to add/remove list items in the future without having to manually edit the...

@JoshDevHub Sounds good to me - I'm sure you and/or others more familiar with Rails and the web app code base would know best how to handle this. The most...

Enjoyed exploring Rails for a bit! And if it's a bug, that makes sense since given the commands like `yarn build:css`, you'd have thought that'd be sufficient for CSS changes...

Had a look through and I see sensible points on both sides. My personal opinion is in favour of editing the README to say > Implement a function that takes...

@kisshore04 as per the [router.param documentation](https://expressjs.com/en/4x/api.html#router.param:~:text=Hence%2C%20param%20callbacks%20defined%20on%20router%20will%20be%20triggered%20only%20by%20route%20parameters%20defined%20on%20router%20routes.), the callback will only be triggered by route params defined within the router. Since `department_id` in your `class-router.js` is a param inherited through `mergeParams:...