Manvi-Agrawal
Manvi-Agrawal
Hi @tcNickolas , I have done some changes to include non-trivial tests as suggested by you in [this comment](https://github.com/microsoft/QuantumKatas/pull/620#issuecomment-849106560) in #621. I am a bit confused about this. > Run...
Hi @tcNickolas @anjbur, I just thought of slightly cleaner approach to refractor the magics from the one mentioned [here](https://github.com/microsoft/QuantumKatas/pull/620#issuecomment-846445000). I am thinking to get away with the generics by considering...
Hi @anjbur, I have changed the code to remove the generics. Unfortunately, I can't do the change [here](https://github.com/microsoft/QuantumKatas/pull/620#discussion_r663280991) due to the reason in the following [comment](https://github.com/microsoft/QuantumKatas/pull/620#discussion_r663308043).
Hi @anjbur. I have now changed the return type of `GetDeclaredCallables` to `IEnumerable` as per your suggestion
Hi @anjbur, I have applied the suggestions as requested by you. And as for the testing changes to magics as per @tcNickolas suggestions described [here](https://github.com/microsoft/QuantumKatas/pull/620#issuecomment-849106560), I made an initial attempt...
Hi @tcNickolas thank you for giving the suggestions [here](https://github.com/microsoft/QuantumKatas/pull/620#issuecomment-878560046). I am hoping to get the changes done by the end of week. I hope that wouldn't be a problem.
Hi @tcNickolas , fortunately I got time to do the changes in [PR#621](https://github.com/microsoft/QuantumKatas/pull/621) as per the suggestions [here](https://github.com/microsoft/QuantumKatas/pull/621). Will try my best on resolving comments.
Hi @anjbur. Thanks a lot for your precious time while reviewing this PR. I have applied the code suggestions through the UI interface. I currently have limited bandwidth, so hopefully...
No problem. I will push my changes after Mid November.
Hi @anjbur, apologies for keeping this PR on on hold. I think it would be good if you could do the final round of edits. TLDR: I have done most...