Maxime Mangel

Results 1077 comments of Maxime Mangel

Adding the flag is good enough to me

> `x.ToString "#,#"` produces the correct string, but I'd appreciate a Fable warning saying that invariant culture will be used (I think I've seen something like that in other places)....

The warning one that I know about is something like if you pass a CultureInfo parameter Fable says, that it will just be ignored. I am just discovering the error...

I am looking at fixing this issue and I am able to fix the first 2 issues. Looking more into these issues, I have the feeling that we are having...

For reference, while we wait for a decision to be taken. To generate an error if no `CultureInfo` is passed for number formatting here is the code that can be...

> Does Fable respect `TreatWarningsAsErrors`? No it doesn't but this is perhaps possible to support it. We can probably retrieve the value of `TreatWarningsAsErrors` when cracking the projects and then...

Just want to add that if a format is not supported, then generating an error independently of `TreatWarningsAsErrors` should be the expected behavior. This is perhaps what you were was...

> In .NET, `CurrentCulture`, which is not a thing in Fable, is used by default. The warning you referenced thus points out a difference in behavior between the platforms, but...

Looking back at this issue, I think we are trying to do too much. What I mean by that is the behavior in .NET when passing an invalid format is...