Maxime Mangel
Maxime Mangel
Hello @Byte-666 , thank you for creating the PR :) As mentioned on the Gitter channel, I reworked the process to package the library. Could you please re-base the master...
> The change I'm awaiting for is when the paket start using the snupkg in the paket pack instead of nupkg. Note that we don't use anymore `paket pack` but...
The test are pulled from [Thoth.Json](https://github.com/thoth-org/Thoth.Json) repo using [paket](https://github.com/thoth-org/Thoth.Json.Net/blob/master/paket.dependencies#L11-L16). By default, you should be able to run the test on your machine because paket should pull the dependencies. It is...
In order, to run the test you should use fake build: `fake.cmd build -t Test` [Source file](https://github.com/thoth-org/Thoth.Json.Net/blob/master/build.fsx#L142-L154) If you want to run the test manually: 1. Run `fake.cmd build -t...
I tried to port it to the next version of Thoth.Json libraries and indeed this fix generates several errors. Unfortunately, my understanding of Reflection code is limited and for now,...
@alfonsogarciacaro I just want to say that I didn't forget your PRs and works. Il will be included in the next major version of Thoth.Json. I am rewriting it deeply...
Thoth.Json.Net is not directly responsible for parsing the JSON. It is using Newtonsoft under the hood. It seems like Newtonsoft is permissive by default... https://github.com/JamesNK/Newtonsoft.Json/issues/818 Unfortunately, there isn't much we...
> What are your thoughts on building a third implementation of Thoth backed by System.Text.Json? Thoth.Json.System? The plan right now, is more to stop having 2 implementations of the library...
Hello @olo-ntaylor First of all thank you for you kind words and always happy to know that my work is used and benefit others :). If one wanted to fork...
@njlr You are right that libraries build on top of Thoth.Json would have more compiler directives in the code. > I strongly support proposal 1. > > A from-scratch, pure...