Maxime Mangel

Results 1077 comments of Maxime Mangel

Finally, "monaco-editor" should be "monaco" But monaco, is a real pain to work with in the browser. Perhaps, the problem is comming from there

@alfonsogarciacaro I think it's generating code when we encounter a `U2, U3, ...` case. Example: ```fs type LatLngExpression = U3 [] module LatLngExpression = let ofLatLng v: LatLngExpression = v...

Why would it be `Fable.Import.Monaco.Monaco` ? Is it because of the d.ts file structure or something on our side ?

@ctaggart Ok I think I see, your point. Thanks for the explanations And seems like your decision was the right one here :)

@ctaggart Do you think @humhei proposition could work ? Any limitation in mind ?

@humhei Can you please detail a bit ?

Indeed perhaps `export as namespace React;` should be a switch on our side to decide how to structure the module.

Short answer is yes we should :) Because the tests are not working in all the cases we should not generate them. More details https://github.com/fable-compiler/Fable/issues/1580#issuecomment-428496491

You should delete ```fs [] module GeoJSON = let ofGeometry v: GeoJSON = v |> U3.Case1 let isGeometry (v: GeoJSON) = match v with U3.Case1 _ -> true | _...

I think they still work indeed because they don't "type check against an interface"