manageiq-schema

manageiq-schema copied to clipboard

[WIP] Set manager_ref to file path for embedded ConfigurationScripts

[{"_id":"67295ee4ef349cf60307e13b","body":"<rubocop \/>Checked commit https:\/\/github.com\/agrare\/manageiq-schema\/commit\/3e3324974122689262fd132540809c37d2e3a19c with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint \n2 files checked, 0 offenses detected\nEverything looks fine. :trophy:\n","issue_id":1715893902308,"origin_id":1810786645,"user_origin_id":7806257,"create_time":1699983625,"update_time":1699983625,"id":1730764516969,"updated_at":"2024-11-04T23:55:16.969000Z","created_at":"2024-11-04T23:55:16.969000Z"},{"_id":"67295ee5ef349cf60307e13c","body":"This pull request has been automatically marked as stale because it has not been updated for at least 3 months.\n\nIf these changes are still valid, please remove the `stale` label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned\/reviewer(s).","issue_id":1715893902308,"origin_id":1951491029,"user_origin_id":7806257,"create_time":1708300811,"update_time":1708300811,"id":1730764517063,"updated_at":"2024-11-04T23:55:17.063000Z","created_at":"2024-11-04T23:55:17.063000Z"},{"_id":"67295ee5ef349cf60307e13d","body":"This pull request has been automatically marked as stale because it has not been updated for at least 3 months.\n\nIf these changes are still valid, please remove the `stale` label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned\/reviewer(s).","issue_id":1715893902308,"origin_id":2119460237,"user_origin_id":7806257,"create_time":1716163213,"update_time":1716163213,"id":1730764517151,"updated_at":"2024-11-04T23:55:17.151000Z","created_at":"2024-11-04T23:55:17.151000Z"},{"_id":"67295ee5ef349cf60307e13e","body":"This pull request has been automatically marked as stale because it has not been updated for at least 3 months.\n\nIf these changes are still valid, please remove the `stale` label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned\/reviewer(s).","issue_id":1715893902308,"origin_id":2309052665,"user_origin_id":7806257,"create_time":1724630429,"update_time":1724630429,"id":1730764517157,"updated_at":"2024-11-04T23:55:17.157000Z","created_at":"2024-11-04T23:55:17.157000Z"}]

The manager_ref is typically used to track the "unique" attribute of an object, for ansible_tower/awx the manager_ref is the job_template.id but for embedded_ansible the manager_ref was nil and the name...

agrare

Fix coverage

[{"_id":"67295e8fe2e079ea8006832d","body":"This issue has been automatically marked as stale because it has not been updated for at least 6 months.\n\nIf you can still reproduce this issue on the current release or on `master`, please reply with all of the information you have about it in order to keep the issue open.\n\nThank you for all your contributions!\n","issue_id":1715893902312,"origin_id":355884629,"user_origin_id":7806257,"create_time":1515387621,"update_time":1515387621,"id":1730764431560,"updated_at":"2024-11-04T23:53:51.559000Z","created_at":"2024-11-04T23:53:51.559000Z"}]

The default rake task actually runs multiple rake tasks under the covers, and so we need to change it to use simplecov, but merge the results, then send those merged...

Fryguy

Move evm:db:reset and similar rake tasks to here.

[{"_id":"67295eede2e079ea80068336","body":"This issue has been automatically marked as stale because it has not been updated for at least 6 months.\n\nIf you can still reproduce this issue on the current release or on `master`, please reply with all of the information you have about it in order to keep the issue open.\n\nThank you for all your contributions!\n","issue_id":1715893902318,"origin_id":353830227,"user_origin_id":7806257,"create_time":1514178008,"update_time":1514178008,"id":1730764525954,"updated_at":"2024-11-04T23:55:25.953000Z","created_at":"2024-11-04T23:55:25.953000Z"}]

Fryguy

Migration for adding vault_credential_id in ServiceTemplate option

[{"_id":"68418e45e8959727000fb0c9","body":"I noticed this PR doesn't remove the old vault_credentials - should it?","issue_id":1716570546330,"origin_id":2122585016,"user_origin_id":52120,"create_time":1716296458,"update_time":1716296458,"id":1749126725742,"updated_at":"2025-06-05T12:32:05.741000Z","created_at":"2025-06-05T12:32:05.741000Z"},{"_id":"68418e45e8959727000fb0ca","body":"> I noticed this PR doesn't remove the old vault_credentials - should it?\r\n\r\nThis will not remove `vault_credentials` because I am not sure if this `vault_credentials` is being used somewhere in other repos. So I maintained it like that...\r\n\r\nI haven't found any place where `vault_credentials` is used. Shall I remove that?","issue_id":1716570546330,"origin_id":2122611142,"user_origin_id":160720663,"create_time":1716297212,"update_time":1716297212,"id":1749126725749,"updated_at":"2025-06-05T12:32:05.748000Z","created_at":"2025-06-05T12:32:05.748000Z"},{"_id":"68418e45e8959727000fb0cb","body":"Yes, let's remove it, especially if a global search can't find it.","issue_id":1716570546330,"origin_id":2123341441,"user_origin_id":52120,"create_time":1716321350,"update_time":1716321350,"id":1749126725754,"updated_at":"2025-06-05T12:32:05.754000Z","created_at":"2025-06-05T12:32:05.754000Z"},{"_id":"68418e45e8959727000fb0cc","body":"@Fryguy done the changes please review\r\n","issue_id":1716570546330,"origin_id":2124509023,"user_origin_id":160720663,"create_time":1716375506,"update_time":1716375506,"id":1749126725758,"updated_at":"2025-06-05T12:32:05.758000Z","created_at":"2025-06-05T12:32:05.758000Z"},{"_id":"68418e45e8959727000fb0cd","body":"<rubocop \/>Checked commit https:\/\/github.com\/jaisejose1123\/manageiq-schema\/commit\/00aa0bcd195981258822e4ca889b641f057751ed with ruby 2.7.8, rubocop 1.56.3, haml-lint 0.51.0, and yamllint \n2 files checked, 0 offenses detected\nEverything looks fine. :trophy:\n","issue_id":1716570546330,"origin_id":2134769985,"user_origin_id":7806257,"create_time":1716888928,"update_time":1716888928,"id":1749126725764,"updated_at":"2025-06-05T12:32:05.764000Z","created_at":"2025-06-05T12:32:05.764000Z"},{"_id":"68418e45e8959727000fb0ce","body":"Backported to `radjabov` in commit aa074797e422e57b0986ba24b119b61783cce9a1.\n\n```text\ncommit aa074797e422e57b0986ba24b119b61783cce9a1\nAuthor: Jason Frey <[email protected]>\nDate: Tue May 28 11:26:10 2024 -0400\n\n Merge pull request #734 from jaisejose1123\/fix_vault_credentials\n \n Migration for adding vault_credential_id in ServiceTemplate option\n \n (cherry picked from commit 2f3bf815a20912876f108a93c2ede8873b1735a4)\n```\n","issue_id":1716570546330,"origin_id":2135827450,"user_origin_id":52120,"create_time":1716919218,"update_time":1716919218,"id":1749126725771,"updated_at":"2025-06-05T12:32:05.770000Z","created_at":"2025-06-05T12:32:05.770000Z"}]

Related PR - https://github.com/ManageIQ/manageiq-ui-classic/pull/9184 **Before** ``` # {:provision=> {:repository_id=>"39", ... :vault_credentials=>"194", }, :retirement=> {... :vault_credentials=>"194",}}}, ``` **After** ``` # {:provision=> {:repository_id=>"39", ... :vault_credentials=>"194", :vault_credential_id=>"194", }, :retirement=> {... :vault_credentials=>"194", :vault_credential_id=>"194" }}},...

jaisejose1123

Backward compatible rails 7 changes

[{"_id":"68418e5116d822f9c40ac5b7","body":"cc @kbrock ","issue_id":1716570546338,"origin_id":2125761839,"user_origin_id":19339,"create_time":1716412623,"update_time":1716412623,"id":1749126737981,"updated_at":"2025-06-05T12:32:17.980000Z","created_at":"2025-06-05T12:32:17.980000Z"},{"_id":"68418e5116d822f9c40ac5b8","body":"Does this PR upgrade the dummy app to Rails 7? Asking because it's changing some of the files within the dummy app.","issue_id":1716570546338,"origin_id":2127311930,"user_origin_id":52120,"create_time":1716475330,"update_time":1716475330,"id":1749126737986,"updated_at":"2025-06-05T12:32:17.986000Z","created_at":"2025-06-05T12:32:17.986000Z"},{"_id":"68418e5116d822f9c40ac5b9","body":"<rubocop \/>Checked commits https:\/\/github.com\/jrafanie\/manageiq-schema\/compare\/8529571f1a45c254fd9f4267c127a52f87a6fd9a~...1d317916dafe96a44a42a105891d26f109718f1d with ruby 2.7.8, rubocop 1.56.3, haml-lint 0.51.0, and yamllint \n3 files checked, 0 offenses detected\nEverything looks fine. :+1:\n","issue_id":1716570546338,"origin_id":2127387183,"user_origin_id":7806257,"create_time":1716477040,"update_time":1716477040,"id":1749126737990,"updated_at":"2025-06-05T12:32:17.990000Z","created_at":"2025-06-05T12:32:17.990000Z"},{"_id":"68418e5116d822f9c40ac5ba","body":"> Does this PR upgrade the dummy app to Rails 7? Asking because it's changing some of the files within the dummy app.\r\n\r\nNo, I'm just dropping some sprockets related files that aren't needed in the dummy app for testing migrations... those sprockets files assume sprocket-rails is required by rails... which is not the case with rails 7 so dropping the needless files is one less thing to deal with for rails 7.","issue_id":1716570546338,"origin_id":2127431297,"user_origin_id":19339,"create_time":1716478263,"update_time":1716478263,"id":1749126737993,"updated_at":"2025-06-05T12:32:17.992000Z","created_at":"2025-06-05T12:32:17.992000Z"},{"_id":"68418e5116d822f9c40ac5bb","body":"> Thought these were required for 6.1\r\n\r\nI think they were deprecated in 6.1 and dropped on 7.0. I guess we never saw the deprecations in 6.1.","issue_id":1716570546338,"origin_id":2129474116,"user_origin_id":19339,"create_time":1716555539,"update_time":1716555539,"id":1749126737996,"updated_at":"2025-06-05T12:32:17.996000Z","created_at":"2025-06-05T12:32:17.996000Z"}]

Extracted from #715 These are backward compatible changes to fix failures in rails 7. Interestingly, detected the typo preventing the down migration from running and also the weird migration stub...

jrafanie

CVE-2024-41946 (Medium) detected in rexml-3.2.8.gem

[]

## CVE-2024-41946 - Medium Severity Vulnerability Vulnerable Library - rexml-3.2.8.gem An XML toolkit for Ruby Library home page: https://rubygems.org/gems/rexml-3.2.8.gem Path to dependency file: /Gemfile.lock Path to vulnerable library: /home/wss-scanner/.gem/ruby/3.2.0/cache/rexml-3.2.8.gem Dependency...

mend-bolt-for-github[bot]

CVE-2024-41123 (Medium) detected in rexml-3.2.8.gem

[]

## CVE-2024-41123 - Medium Severity Vulnerability Vulnerable Library - rexml-3.2.8.gem An XML toolkit for Ruby Library home page: https://rubygems.org/gems/rexml-3.2.8.gem Path to dependency file: /Gemfile.lock Path to vulnerable library: /home/wss-scanner/.gem/ruby/3.2.0/cache/rexml-3.2.8.gem Dependency...

mend-bolt-for-github[bot]

CVE-2024-39908 (Medium) detected in rexml-3.2.8.gem

[]

## CVE-2024-39908 - Medium Severity Vulnerability Vulnerable Library - rexml-3.2.8.gem An XML toolkit for Ruby Library home page: https://rubygems.org/gems/rexml-3.2.8.gem Path to dependency file: /Gemfile.lock Path to vulnerable library: /home/wss-scanner/.gem/ruby/3.2.0/cache/rexml-3.2.8.gem Dependency...

mend-bolt-for-github[bot]

[WIP] Add rails 7.1 and 7.2 support

[]

Depends on: - [x] https://github.com/ManageIQ/activerecord-id_regions/pull/40 Merge and release High level: YAML `serialize` is going out of style and we should convert as many to json or other types if possible....

jrafanie

CVE-2025-43857 (High) detected in net-imap-0.5.6.gem

[]

## CVE-2025-43857 - High Severity Vulnerability Vulnerable Library - net-imap-0.5.6.gem Ruby client api for Internet Message Access Protocol Library home page: https://rubygems.org/gems/net-imap-0.5.6.gem Path to dependency file: /Gemfile.lock Path to vulnerable...

mend-bolt-for-github[bot]