manageiq-schema icon indicating copy to clipboard operation
manageiq-schema copied to clipboard

Backward compatible rails 7 changes

Open jrafanie opened this issue 1 year ago • 5 comments

Extracted from #715

These are backward compatible changes to fix failures in rails 7. Interestingly, detected the typo preventing the down migration from running and also the weird migration stub issue where the it's defined in the test itself.

jrafanie avatar May 22 '24 21:05 jrafanie

cc @kbrock

jrafanie avatar May 22 '24 21:05 jrafanie

Does this PR upgrade the dummy app to Rails 7? Asking because it's changing some of the files within the dummy app.

Fryguy avatar May 23 '24 14:05 Fryguy

Checked commits https://github.com/jrafanie/manageiq-schema/compare/8529571f1a45c254fd9f4267c127a52f87a6fd9a~...1d317916dafe96a44a42a105891d26f109718f1d with ruby 2.7.8, rubocop 1.56.3, haml-lint 0.51.0, and yamllint 3 files checked, 0 offenses detected Everything looks fine. :+1:

miq-bot avatar May 23 '24 15:05 miq-bot

Does this PR upgrade the dummy app to Rails 7? Asking because it's changing some of the files within the dummy app.

No, I'm just dropping some sprockets related files that aren't needed in the dummy app for testing migrations... those sprockets files assume sprocket-rails is required by rails... which is not the case with rails 7 so dropping the needless files is one less thing to deal with for rails 7.

jrafanie avatar May 23 '24 15:05 jrafanie

Thought these were required for 6.1

I think they were deprecated in 6.1 and dropped on 7.0. I guess we never saw the deprecations in 6.1.

jrafanie avatar May 24 '24 12:05 jrafanie