MalcolmBoura

Update attachInterrupt.adoc

1

Race hazards should be mentioned on this page. Nick Gammon's notes are misleading regarding single byte variables and I can't find any way to contact him easily.

Update noInterrupts.adoc

1

I have proposed a change to the interrupts() page regarding races.

I have proposed changes to the noInterrupts() and interrupts() pages referring readers to this page.

Update PROGMEM.adoc

2

The strings have to be in flash whether they are loaded at start up (the default) or when needed. Hence using embed or the F macro should have no impact...

The scratchpad and its manipulation should be encapsulated in a class. I have one in preparation. Using a scratchpad class is the best way to fix #189.

setResolution() and other functions looping over devices inefficient and dangerous.

1

setResolution() and other functions looping by index exhibit O(n^2) duration. They also send DS18 commands to every device on the bus, even those that are not DS18, which wastes time...

Dubious code in printFloat(double number, uint8_t digits)

2

A function named printFloat that prints a double is unfortunate naming! https://github.com/arduino/ArduinoCore-avr/blob/2ff00ae7d4e85fa422b7918ee12baf56a1f3006e/cores/arduino/Print.cpp#L229 The comment indicates a problem. It works but empirical constants are not good practice! The range check is...