MakeShiftArtist

Results 19 comments of MakeShiftArtist

I considered this a bug because it's not behaving like I would expect it to, but you could list it as a feature request by using this to allow users...

@KSDaemon I'm going to make a pull request with type support for Wampy when I'm finished, but I wanted to ask first if it was okay if I changed all...

I actually decided to avoid using JSDOC all together and instead do a full [rewrite](https://github.com/MakeShiftArtist/wampy.js) in TypeScript. It's about 98% done, I just gotta test to make sure it is...

@KSDaemon I have a question about a specific property. The [_ws](https://github.com/KSDaemon/wampy.js/blob/c94adab641f0dd89ef53211bfa7ee341825158d0/src/wampy.js#L147) property is typed with JSDOC as an Object, but it's created as a constructor. In `getWebSocket` it's shown as...

> Regarding `getWebSocket` and 5 params: wampy works in both: node.js and browser environments. In node there is no standard ws object with same api as in browser. But, there...

@KSDaemon The `npm run test` error ``` npm run test > [email protected] test > npm run test:node && npm run test:browser > [email protected] test:node > NODE_ENV=test nyc ./node_modules/mocha/bin/mocha --exit --require...

> Wow! Huge work! Thanks @MakeShiftArtist ! I need some time to review. I've enabled ci. So you can now see check results. Seems that something is broken. ``` Run...

> First comment-question: i see a `map` file for every source file. Why are they here? I mean under the source control? I think they are just for debuging a ...

> Also as sources are now in typescript, we should adopt ci and test runner process. I agree, but am not experienced enough with this process to give much insight....

Reviewing some of the failed checks, it appears that the checks are still expecting JavaScript code but failing due to it checking the source files instead of the dist files....