Maggie Kimani

Results 16 comments of Maggie Kimani

> I don't think we should be using the GetHashCode override for multiple reasons: > > * it's not its intended use, especially if caller want to store the hash...

> > The conversion library has many settings. To control these settings we should provide a command line parameter that points to a settings file that configures the behavior of...

> @MaggieKimani1 Why is this a breaking change? Could this not be implemented in the current V1.x branch? You're right, this isn't a breaking change. I have rebased the branch...

@garethj-msft, do you mind sharing the csdl file for me to reproduce the above scenario?

Closing this issue in favour of JSON schema support in 3.1.

Closing the issue as this seems to be working correctly using the following code snippet: ``` c# // Arrange var outputStringWriter = new StringWriter(CultureInfo.InvariantCulture); var writer = new OpenApiJsonWriter(outputStringWriter, new()...

@funkeyfreak we're considering taking a dependency on an external JSON schema library so maybe just hold off on creating a PR.

Hi @msolujic This work is set out to go with our 2.0 release early next year. We're working on a couple of breaking changes hence the hold up.

Hi @msolujic, we've finished working on this issue but we're currently working on other breaking changes that need to go out with the v2.0 release. ETA for the preview release...