Maddiaa

Results 23 comments of Maddiaa

Hey, thank you for doing this! This is good stuff and I will likely merge it and I can see it follows the approach of the duplicate_macro methods introduced recently!

The example in ERC721 is common throughout a lot of contracts in huffmate, another larger bit of work would involve namespacing the labels further to the macro in which they...

Hey @mihoward21 thanks for reviewing. I like the latter pattern as it matches what people are already familiar with with libraries like `ethers`. I'll wire up `createSplit` with the pattern...

That's awesome work I'll absolutely play around with it! Apologies I never finished it up. The api you've ended up with looks awesome

Hi, I'm so sorry that this got lost in my mentions, **value** support has been added but **from** has not yet. I should be able to work on the latter...

Looks like a good improvement thank you. @clabby wdyt

Looking into Merlin it appears that it is already using keccak as its hash function? (based on https://github.com/dalek-cryptography/merlin/blob/53535f32e6d6de421372d67f56176af0c0f55fd7/src/strobe.rs#L97)

As mentioned here: https://github.com/AztecProtocol/aztec-verifier-contracts/pull/23#issuecomment-1544299197 we purposely have the verifier calls as external library calls to ensure that they are writing into clean memory. The solution should be to swap the...

As the verifier uses hardcoded memory accesses ( and does not continue from the free memory pointer ), we do not want to enable contracts to inherit from the Verifier...

hahahha incredible, ill take a closer look at this tomorrow, tagging @Philogy for the vibes