mpocwierz comments

Results 6 comments of


                                            mpocwierz

Memory leak in Json$NullJson

@slaskawi Thanks, this is exactly what we did (at least from what I see, because whitespace changes make your diff hard to read). It works for us, but would be...

AWS::Events::Rule / MaximumRetryAttempts causes drift detection false-positive

Any news on this? I'm seeing this exact problem with one of my stacks.

Feature: Support dependencies accessed over SSH in containerized builds

@qingchm Thanks for your review. I spent some time to resolve conflicts that arose between my branch and `develop`. Regarding your comments: - Using pathvalidate library: I removed this lib...

Feature: Support dependencies accessed over SSH in containerized builds

@qingchm, @hawflau Did you have some time to look into this?

Feature: Support dependencies accessed over SSH in containerized builds

> Thanks for this PR @Macok, I've updated your branch with latest from develop. I will check with @qingchm to see UX feedback. Thanks @mndeveci , let me know once...

Support ssh git dependencies in pip requirements.txt when building with use-container

I implemented this in #3084. With this change, the host's SSH configuration can be forwarded to the container by mounting ssh-agent socket. ``` sam build -u --container-dir-mount $SSH_AUTH_SOCK:/ssh-agent -e SSH_AUTH_SOCK=/ssh-agent...