Results 589 comments of MSP-Greg

> This avoids systemd unnecessarily restarting puma after a restart has just completed. I have a few other things to look at, but this makes sense. Last time I was...

Fine by me. Note that previously there have been [5.0-Upgrade.md](https://github.com/puma/puma/blob/v5.6.9/5.0-Upgrade.md) & [6.0-Upgrade.md](https://github.com/puma/puma/blob/v6.6.1/6.0-Upgrade.md) files. I just noticed them... We could also add a 'Notes' section to the existing format, and use...

@brian-goldman Thanks for the report. https://github.com/puma/puma/blob/ef2c6aae78a5df5ceb6126045768e474fe2b51be/lib/puma/server.rb#L209-L218 This might be platform/OS dependent. Can you try adding the following line between 216 & 217? ```ruby return false unless state ```

Interesting. The code works with curl on Ubuntu (I already had JRuby 9.4.8.0 installed). Regardless, easy fix and the statement is 'low-overhead'... PR soon.

> Did it cause any issue? No. Just seemed like a waste. I guess it's a distinction between storing more caches on GHA or hitting RubyGems.org more... Example, which will...

> Does state == nil always mean that the socket is still open? Do we have more information about what's happening there? No, I'm guessing it means that the constants...

> Do they require a thread to keep the websocket connection alive? Websocket doesn't require a thread, but it also can't be 'downgraded', so it's different than `ActiveStorage::Streaming'?

I see a feature like this as being beneficial, in particular when a backend has requests that take much longer than the average, and that's known in advance. It could...

@dentarg Try replacing: https://github.com/puma/puma/blob/89a448e51b9ba22d46a7a6108fb4787623290dc2/lib/puma/server.rb#L389-L395 With: ```ruby if @options[:workers] > 1 delay = 0.0001 * ((@reactor&.reactor_size || 0) + pool.busy_threads * 1.5)/max_flt sleep delay end ``` This should keep the behavior...

You mentioned 'if I remove this sleep'. The change should have the same effect? **EDIT:** for `-w1`