MSP-Greg

Questions about exception/error handling during request processing and up to and including calling the app. I believe there are four types of exceptions: A. A socket error. B. An invalid...

I'm working on a significant update to this, currently cleaning up tests. When I'm finished, I'll help review PR's.

Today's Puma has grown quite a bit from its origins. Over time, `server.rb` (and also `test_puma_server.rb`) have often been the 'catch all' files for new features. Back in October of...

Not sure whether to open an issue regarding this. The issue is when should `lowlevel_error_handler` be called. I believe there are five cases: 1. The request is invalid based on...

Rebased and also reran failed TruffleRuby job.

@eregon For a long time, ruby-loco had code to modify the binstubs in all windows builds. On 10-Oct, I removed it, as RubyGems/Bundler updated their code. I'm looking at it....

@eregon This is kind of strange, and I could repro it locally. Now that I check the title, it's not correct. The issue is that `which` cannot find the bundle...

@pdalberti Thank you for the report. This involves some legacy problems going back a long time... See #2871, #2870, https://github.com/rack/rack/issues/970. #2871 added: https://github.com/puma/puma/blob/4d7f4e77bde20df51bfad4d8a1f290273c6b1fe7/lib/puma/request.rb#L475-L477 If we change that to the below,...

> How about adding the two values together (guarding for nil values)? Was there a reason why that approach was not selected? Really, line 477 shown above should not exist...

As mentioned above, I believe `HTTP_VERSION` is only used by Rack 2.2.10 in statements like the following: ```ruby env[HTTP_VERSION] ||= env[SERVER_PROTOCOL] ``` So, nothing in Rack depends on the value....