MRIIOT comments

Results 80 comments of


                                            MRIIOT

Publish data from multiple connections to a single output

I have been trying to figure out how to support this, not only for this project but some of our other code that moves and transforms data. https://github.com/Ladder99/Derail

Allow alarms and operator messages to be output as a dictionary.

Pushing out to 0.8.

Docker: Keep logs in a separate location from config files

All logging goes through NLog, so changes inside of `nlog.config` would affect both application and NLog internal logs. And then another volume mapped to `/var/log/fanuc` would resolve this.

Docker: Keep logs in a separate location from config files

https://github.com/Ladder99/fanuc-driver/blob/main/examples/windows/nlog.config Modify Docker nlog.config and document adding another volume for logs.

Move all FOCAS library files in a separate folder

Need to test this across operating systems: https://docs.microsoft.com/en-us/windows/win32/dlls/dynamic-link-library-search-order?redirectedfrom=MSDN

Move all FOCAS library files in a separate folder

Non-functional and potentially breaking cross-platform support. Removing milestone.

docs: What configuration in `config.yml` is necessary?

`l99.driver.fanuc.FanucMachine, fanuc:` are the configuration properties for machines[id].type.

docs: What configuration in `config.yml` is necessary?

Agreed, `machine.broker` is misleading.

docs: What configuration in `config.yml` is necessary?

@tukusejssirs configuration has changed. It is somewhat modular. https://github.com/Ladder99/fanuc-driver/blob/develop/fanuc/config-example.yml

docs: What configuration in `config.yml` is necessary?

> As for the new config, could you better describe it? Or even better: update the [docs](https://docs.ladder99.com/en/drivers/base-driver) and move them to [`fanuc-driver` docs](https://docs.ladder99.com/en/drivers/fanuc-driver) (or at least provide a link to...