Results 160 comments of Matthias Deiml

Sadly no. I'm not talking about the return value of `iter_matches` which is an iterator over `pattern_id, match` pairs. I'm talking about the `match` part of these pairs which is...

You are right that chidren should be excluded. I wasn't aware there was a tree-sitter documentation for this. So there should definitely be some kind of `@include-children` predicate, which would...

I think the `Query:iter_matches()` API is already in stable neovim, so the way this is implemented now is a breaking change. Is a breaking change okay in this case because...

1. Pretty much every plugin that uses `Query:iter_matches()` directly will error, since the output type changed. 2. Relying on the old behavior is sometimes reasonable as it works fine with...

What would be the preferred solution for directives / predicates? They also obtain the same `match` object, but for those there is no easy way to "opt-in" to the new...

This is just guessing, but performance for queries that don't have quantifiers should be similar, with the extra overhead of creating a table with one element. Highlight needs the `all_captures...

There will only be one match with multiple nodes.

(I removed the commit for defaulting to the old behavior, as we decided to "rip the band-aid off")

This should be ready for review