Matthew Bradbury

Results 26 comments of Matthew Bradbury

Hello @ronf, it looks like I was incorrect with option 1. As this ends up typing as `SSHClientProcess[Any]` when `input` is not provided, which makes my warnings go away, but...

I see, it looks like I came to the same conclusion as you. I have installed mypy and it looks like it picks up the type as `SSHClientProcess[AnyStr]`.

With my PR, I no longer get an incomplete type with PyLance (which uses pyright). I have been doing something similar to: ```python import asyncssh async with asyncssh.connect( "192.168.0.1", username="user",...

For PyLance With asyncssh-2.14.0 from PyPI: ![image](https://github.com/ronf/asyncssh/assets/2089920/1a2fa2dd-16f0-494b-8754-520dc6765155) With the current develop: ![image](https://github.com/ronf/asyncssh/assets/2089920/6a2fb827-0c87-41ee-9790-5b1aee027bcf) With my PR: ![image](https://github.com/ronf/asyncssh/assets/2089920/5e003f08-adcc-42ce-9d1f-305b12fc2ba2) For mypy, it doesn't seem to provide a type for the pwn process: With...

Thanks for taking look @ronf, it has been greatly appreciated. I did wonder what the default value of tuple was intended to achieve, so that makes sense. Also understandable that...

I am interested in this implementation. However, I would prefer to see that the RE-Mote's hardware support for EC operations was used instead of MicroECC. This would avoid the need...

Just a note that I added some type hinting to help me understand the code. Happy to remove if needed.

> Thanks for the changes. they look comprehensive. I also appreciate the type hints. > > I'm curious though if there was a way to keep the inheritance of `LpAffineExpression`...

I have tried to decouple LpAffineExpression from its dict base class, but this has led to test failures I cannot get to the bottom of. This commit can be found...

Looks like `LpConstraint` needs a `asCplexLpAffineExpression` method that calls the method of the same name on `expr`. Or the test can be updated to use `LpProblem.objective.expr.asCplexLpAffineExpression` instead of `LpProblem.objective.asCplexLpAffineExpression`.