Merlin Bögershausen

Results 32 comments of Merlin Bögershausen

I came to hightlight.js because I use Aciidoc-revealjs to create my slide decks and the has the best support for hightlight.js. I never worked with prism and only contributed some...

see https://github.com/openrewrite/rewrite/compare/main...MBoegers:rewrite:3623-%24-as-inner-class#diff-4c3061e863c60e5a5391eb3c2b843b66b4113096c6527d0c09029d3338484b9e for reproducer

I may found the Spot, [org.openrewrite.java.internal.template.Substitutions L155](https://github.com/openrewrite/rewrite/blob/fb7dbd6c95ef5492301dcb941e7f8eefd223621e/rewrite-java/src/main/java/org/openrewrite/java/internal/template/Substitutions.java#L155) replaces all $ which are used as delimiter Same for JavaType#build Line 572

First of all, thanks an no worries. Its rarely used and I mentioned working on it ;). I just documented my find as I try to understand the purpose of...

I think I made some progress. - TypeUtils.toFullyQualifiedName seem to handle $ better (see [TypeUtilsTest L 150 following](https://github.com/openrewrite/rewrite/compare/main...MBoegers:rewrite:3623-$-as-inner-class#diff-11e9181d7f5fc01636de0bf3331ddc98f39c3eef14fd0d63020757d95bf6f638R250-R288)) - All occurrences of String.replace("$", ".") in rewrite-java* now use TypeUtils.toFullyQualifiedName (namely...

The current recipe implementation replaces the constructor with the initialize method. Applying this logic to the `BaseTest` and deleting the constructor may conflict with other usages. This could lead to...

I've implemented a test case to reproduce in [ParameterizedRunnerToParameterizedTest](https://github.com/openrewrite/rewrite-testing-frameworks/blob/1a85415653f74af623c75a39ef9fc14acafe940a/src/test/java/org/openrewrite/java/testing/junit5/ParameterizedRunnerToParameterizedTest.java#L586) and implemented a first version of the required changes in the test methods. Currently the migration of the base class is...

@knutwannheden thanks for the offer, but first let me close #217 ;)

I'll start with this one.

While implementing the handling of `var`for generic constructor invocations, I noticed that it may be hard to handle *normal* method invocation within the same recipe. That's why I decided to...