Valery Mironov comments

Results 137 comments of


                                            Valery Mironov

Grapheme cluster, normalization, collation

@lemire Hello, would you interested to discuss the appropriate API/implementation for this? I think I would be interested in implementing this for simdutf during my weekends. Especially since there are...

cmake fails if ICU_ROOT is used with source

https://github.com/iresearch-toolkit/iresearch/blob/master/cmake/FindICU.cmake#L131

After updating to version 3.11.7 of Arango BD, the service is constantly restarting

Hello, @DarkDeddok Can you run on machine after crash something like? ``` coredumpctl debug frame 3 ```

Fix CI for MinGW

https://github.com/simdjson/simdjson/blob/master/.github/workflows/msys2.yml yep it works

Optimize co_return Future<V, E> from Future<V, E>

Here/Next now should be implemented for ReturnAwaiter, not for PromiseType

Optimize co_return Future<V, E> from Future<V, E>

Also same needs for Task

Optimize co_return Future<V, E> from Future<V, E>

@chethan27 Hello, cool! One moment. Now co_await single future was optimized. So implementation suggested in this issue is impossible. Instead you need to make Return awaiter a derived from InlineCore,...

Can't compile as sub-dependency

https://github.com/google/s2geometry/pull/285 Also fixed in s2, don't think it's best solution but works for us

Is it expected such test doesn't work with sanitizer?

@derekmauro I probably wasn't clear enough. Something like this explain better. ```cpp TEST(Table, ReservedTemp2) { if (!SwisstableGenerationsEnabled()) GTEST_SKIP()

Is it expected such test doesn't work with sanitizer?

@derekmauro Hello, is it reproduce issue for you? Or I need to provide something else? It's different test. It's not in your CI now. It's about two cases: 1. Unsigned...