Valery Mironov comments

Results 137 comments of


                                            Valery Mironov

Is such combining with apache 2.0 license correct?

> Both the Apache License and the MIT license are permissive, so incorporating MIT licensed code into your Apache licensed project is certainly allowed > incorporating MIT licensed code into...

Points only optimization doesn't exist for indexing

https://github.com/google/s2geometry/pull/296/commits/da933587ab1f8c162d31462e6b3e2036fa72c9fe

Points only optimization doesn't exist for indexing

https://github.com/google/s2geometry/pull/296

Points only optimization doesn't exist for indexing

@smcallis @jmr What do you think?

Points only optimization doesn't exist for indexing

Ok!

s2 cannot handle more than 2^31 - 1 vertices in polyline/polygon

I agree it's not very realistic, but at the same time it is just strange. Also I think it is possible in more simplified case: For an example if you...

s2 cannot handle more than 2^31 - 1 vertices in polyline/polygon

Nice, thanks!

s2 cannot handle more than 2^31 - 1 vertices in polyline/polygon

I agree it a lot of places, I just noticed difference between serialization and runtime and decide to ask, do you plan to fix runtime or not

intersects or not slow

Not, it's customer data but I can describe it. https://github.com/google/s2geometry/discussions/290 X polygons is rectangles, and Y is any S2Loop But I think it's concrete case in general I want to...

intersects or not slow

@jmr What do you think about add something like ``` Intersects(S2Polygon& lhs, S2Polygon& rhs) { if (lhs.num_loops() == 1 && rhs.num_loops() == 1) { return lhs.loop(0).Intersects(rhs.loop(0)); } current expensive code...