Lzzzt

Results 18 comments of Lzzzt

are there some ways to run benchmark between tokio version and current version

> > is that what you want? @oldherl > > Yes. Is that your fork? yes, I'm about to submit a PR.

should these accessor like `BlockingAccessor` that doesn't store the metadata but change the capability add a field to store the new metadata to avoid needless memory allocation. https://github.com/apache/opendal/blob/31d09673093d92a87e72575d1b00bdd4529dcf56/core/src/layers/blocking.rs#L183-L187

It seems that after apply this change, the c binding CI test will fail, but I don't know why this happens.

> Sorry for ignoring this for so long! Would you perhaps like to rebase this? I promise I'll review it quickly. :) OK

> Sorry for ignoring this for so long! Would you perhaps like to rebase this? I promise I'll review it quickly. :) I'm done

> Ok, so I'm thinking: Perhaps this should be a frontend option like the sorting method and sorting order? It would be consistent since it's a display thing like those...

> There could be a button in the "Size" row that would allow you to toggle this (and it'd change the query parameter). It seems there is no suitable place...

> Do you want to rebase this and for the time being just exchange `--show_size_in_byte` for `--size-display` with an `enum` that is either `human` or `exact`? I'd like to get...