Kevin Liu

Results 14 comments of Kevin Liu

> Also we might need to add a test for it I’ll try adding a unit test for it.

Hi, I attempted to refactor the logic into a function. This refactoring provides the following benefits: 1. Modularity: encapsulates the pre-import logic in a dedicated function 2. Easier testing: allows...

> @Lzzz666 would you be able to take a look at the review comments on this PR? @amoghrajesh I might need some help or discussion regarding the location of the...

Hi @ephraimbuddy, I’m not familiar with the scheduler, but based on the [Dag File Processing](https://airflow.apache.org/docs/apache-airflow/stable/administration-and-deployment/dagfile-processing.html) documentation, I think the pre-import function is executed in the DagFileProcessorProcess stage, which runs in...

Correct me if I’m wrong, but when I traced the code, it appears that `proc: Self = super().start()` fork parent process to create the child process. If the goal of...

I’ll refer to the experiment in #30495 and provide benchmark results.

I found that with the current pre_import implementation (#30495), the performance gains are negligible in airflow 3 —probably because it only pre-imports the Airflow modules actually used in each DAG....

I’m not entirely sure, but if we want to pre-load all the core Airflow modules—instead of, as before, pre-loading only the modules required by the current dag file before forking—should...

I ran a benchmark comparing three loading strategies: 1. Pre-import before parsing loop Call `_pre_import_airflow_modules()` once before entering the while loop in _run_parsing_loop(). 2. Pre-import before fork Call it right...