Lukas Tyla

Results 343 comments of Lukas Tyla

@gerdadesign Could you have a look at the live [time picker](https://deploy-preview-7958--material-ui-x.netlify.app/x/react-date-pickers/time-picker/) and [date time picker](https://deploy-preview-7958--material-ui-x.netlify.app/x/react-date-pickers/date-time-picker/) examples and comment on the UX behavior? The main I see: - Should the `meridiem`...

> I'd like to have your opinion on the following diff: Oh, that looks great! ❤️ Want me to include it with this PR? Or are you planning on making...

> I'm wondering if there is a way to prevent this additional view complexity. Could we set the renderer dynamically in the component? I was also debating on the best...

### Replying to @joserodolfofreitas comments. > I was wondering if we should snap the selection on the top like ant-design. I noticed there's a mechanism that sometimes snaps the selection...

> My initial guess, as an end-user, was that it's a composite widget like in https://www.telerik.com/kendo-react-ui/components/dateinputs/timepicker/ so that it works with the arrow key, but it probably doesn't matter, this...

> > should we only close the picker after [the meridiem] is changed/confirmed? > > I do think we should click AM / PM before closing. It's less friction for...

> > That is already a feature supported out-of-the-box given our pickers architecture. > > Maybe we could change the default visibility of this button on the desktop time picker...

@gerdadesign Do you think we should do something with this edge-case layout (DateTimePicker with tabs shown (hidden by default) and `ampm` turned off)? ![Screenshot 2023-03-30 at 22 39 50](https://user-images.githubusercontent.com/4941090/228946856-6dead5ac-37e4-4fb0-93f7-629929e14728.png)

I've experimented with a hybrid `timeStep` prop type of `number | ((view: TimeView | 'single-column') => number);` and think that it creates some edge-cases (in regards to resolving when to...

### Replying to @gerdadesign comments: > * I'm wondering if I'm missing something here, but I would expect this to work like the scroll bar for [lists](https://mui.com/material-ui/react-list/#virtualized-list). (Chrome; Mac) thumb...