Lukas Reschke

Link displayed incorrectly in settings dropdown if image is bigger than 16x16px

2

Link is "Help123"

``` php /** * @NoAdminRequired */ public function editCalendar() { $calendarid = (int) $this -> params('id'); $pName = (string) $this -> params('name'); $pActive = (int) $this -> params('active'); $pColor =...

Ought really to be non-static for unit-test purposes ## --- Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/24505876-oca-calendarplus-calendar-should-be-non-static?utm_campaign=plugin&utm_content=tracker%2F19394737&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F19394737&utm_medium=issues&utm_source=github).

Spaces and tabs are mixed - this makes the code look very confusing in a proper IDE and also the GitHub web interface:  @libasys In core we stick to...

## --- Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/24506150-add-some-unit-tests-speak_no_evil?utm_campaign=plugin&utm_content=tracker%2F19394737&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F19394737&utm_medium=issues&utm_source=github).

Does not belong there. Use something like `script('calendarplus', 'foo')` in the respective template file. Ref https://github.com/libasys/calendarplus/blob/67828765919e0006719bfce50709c4166b490c33/controller/pagecontroller.php#L83-L112 ## --- Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/24506100-move-ocp-util-addscript-and-co-out-of-the-controllers?utm_campaign=plugin&utm_content=tracker%2F19394737&utm_medium=issues&utm_source=github)** We accept...

``` php private $userId; private $l10n; private $configInfo; public function __construct($appName, IRequest $request, $userId, $l10n, IConfig $settings) { parent::__construct($appName, $request); $this -> userId = $userId; $this->l10n = $l10n; $this->configInfo =...

Against the oC coding guidelines and looks ugly :speak_no_evil: ``` php $userConfig = json_decode($this -> configInfo -> getUserValue($this -> userId, $this->appName, 'userconfig')); ``` vs. ``` php $userConfig = json_decode($this->configInfo->getUserValue($this->userId, $this->appName,...

Remove everything that calls \OC::$server and use DI instead ## Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/24506167-use-dependency-injection-consequently?utm_campaign=plugin&utm_content=tracker%2F19394737&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F19394737&utm_medium=issues&utm_source=github).