Luca Ziliani

Results 11 comments of Luca Ziliani

>I think it's because pnpm uses symbolic link inside node_modules. Someone is aware of it? any suggestion?

@JoshuaKGoldberg If you declare a value fo type `number | undefined` you would check it against a number or `undefined`, not `null`. Of course `undefined == null` is true and...

Additionally `null` value is not assignable to a variable of type `number | undefined`. I think this creates confusion.

@JoshuaKGoldberg the confusing part is the second change of the PR https://github.com/typescript-eslint/typescript-eslint/pull/5588/files#diff-ae8706b9da06d32dab19a7fd207086b7fe8ed718bf4a3bc1d5b9a0af1284c710L70 (the first change can be rollbacked): ``` let num: number | undefined = 0; if (num != null)...

It's well know you can use `== null` to check both `null` and `undefined`. But they are not semantically equal: `undefined` means "not defined" and `null` means "empty" and they...

You said right `T | null | undefined` not `T | undefined` like you are argiung/defending. That's why I sustain to use/compare value according with its explicit type declaration.

@JoshuaKGoldberg Are you comfortable with that change https://github.com/typescript-eslint/typescript-eslint/compare/main...Luk-z:typescript-eslint:Luk-z-patch-strict-boolean-expressions-nullable-numbers I can create new PR or you can re-open https://github.com/typescript-eslint/typescript-eslint/pull/5588 and i push last commit.

this should be absolutely implemented, maybe `pnpm up --peer` ?

> @vanessayuenn would you consider having a more fine-grained control of zooming feature for docs, so people could disable it in elements like popovers and context menus, that fixed positioning...

Ok, but this definitley not a bug, maybe open a feature request?