Alex Yolkin

Results 9 comments of Alex Yolkin

Agree. But what will happen with projects, that already use this library? I don't think that they have tests for quotes, and this change can broke them.

ok, changed patch as you said

> `String` and `MarshalText` should be dropped as well, otherwise ETags will get double-quoted. Done

That's why I worried about remove String method. Let's I return it and in server call internal.ETag(ao.ETag).String() ?

Nope. String() method, that I was removed, is adding quotes to ETag value. This is not the same string(ao.ETag)

Where my changes add quotes in code ? `w.Header().Set("ETag", ao.ETag)`

Removed wrapper, with call String() method on it. I think it will broke server in setting ETag to headers

Could you please explain, why need write type conversion here?

Try to disable SSE4_1 for x86. Because not all processors support it.