Lucas Ste comments

Results 82 comments of


                                            Lucas Ste

Coverage: Unhandled AST nodes

> There are a few AST nodes that are not handled by the coverage visitor: > > Unhandled: > > * `YulSwitch` > * `YulForLoop` > * `YulFunctionDefinition` > *...

Create switch instruction

> LGTM, although it could use some more tests (e.g. no cases and no default at all, multiple default cases, duplicate cases, etc...) 1. `no cases and no default at...

Create switch instruction

> > LGTM, although it could use some more tests (e.g. no cases and no default at all, multiple default cases, duplicate cases, etc...) > > 1. `no cases and...

Create switch instruction

@seanyoung and @xermicus I am requesting your review again as I implemented Cyrill's suggestions.

Make Solang compiled contracts compatible with Anchor

It is not on this list, but many instructions utilize ABI encoding and need to be modified. One example is `Instr::AssertFailure`. Its arguments are ABI encoded in `emit`. That must...

Solang does not implement address.code

> Same here while compiling an ERC721. > > Did you find a workaround @LucasSte ? We haven't found a solution yet. Can you provide more details on what you're...

Build the AST before running semantic analysis

Please, @seanyoung and @xermicus, join the discussion!

Compiler enters unreachable code when building for Solana

> Once we switch to borsh encoding, this problem goes away. @seanyoung Yes, this is why I haven't touched this issue.

Compiler enters unreachable code when building for Solana

Closed by #1053

Solang's intermediate representation should use SSA

Please, @seanyoung and @xermicus, join the discussion!