Lucas Hill

Results 7 comments of Lucas Hill

@rwjblue Could you comment on whether ember-cli plans to support PnP? Our team is reviewing options for where to go after yarn v1. @shamrt If you are using ```nodeLinker: node-modules```...

> @LucasHillDex shouldn't `this.router.transitionTo()` just work? `this.hostRouter.transitionTo()` per https://ember-engines.com/docs/deprecations#-use-alias-for-inject-router-service-from-host-application yes would do transition in the context of the host app. @SergeAstapov Being that this is the host router you would...

@SergeAstapov I came up with a minimal example to demonstrate the issue we're having: https://github.com/LucasHillDex/engine-routing This is a simple routable engine addon. It has two routes, "first" and "second". In...

@SergeAstapov I don't think I addressed your response properly, ember-engines does not allow you to inject the plain 'router' service anymore, as I believe that was still just the host's...

> @LucasHillDex have you seen https://github.com/villander/ember-engines-router-service? This addon preserves the encapsulation you're looking for when routing via service within an engine. I ended up finding my own workaround but that...

I think an option for the rule that could be useful is similar to "except-simple" where assert.expect is required in tests with asserts in blocks etc, but all other assert.expects...

@chancancode are you primarily maintaining this repository? Just curious on your thoughts.