Joe Clack comments

Results 113 comments of


                                            Joe Clack

[node] Fix `http.createServer` signature

The build is failing now because of a breaking release to `@npm/types` [here](https://github.com/npm/types/releases/tag/v2.0.0)

[node] Fix `http.createServer` signature

The build is failing because ... no good reason ? 😩

[node] Fix `http.createServer` signature

Yes, and what's that got to do with this PR?! I haven't touched that module at all! 😭

[node] Fix `http.createServer` signature

Are there any actions I need to take here, other than waiting for a review?

[node] Fix `http.createServer` signature

> That is a new 5.7 break we are going to fix on master (sorry...) bahaha, don't worry about it :joy: I was mostly worried I might have to resolve...

[node] Fix `http.createServer` signature

Ready to merge

[node] Fix `http.createServer` signature

> please revert Reverting isn't the play here - this PR makes the types more correct. We should look into fixing the issue properly. I haven't had a chance to...

[node] Fix `http.createServer` signature

What confuses me is that some typescript versions correctly recognise the type as `Server` but others expand out the response type into some huge object type `Server`? This seems to...

Generic type narrowing for truthy check has inconsistent / incorrect behavior

Posting what I believe is another way of reproducing this: ```ts const foo = { bar: ['hello', (value: 'hello' | 'bye') => {}], baz: [3, (value: 3 | 5) =>...

Generic type narrowing for truthy check has inconsistent / incorrect behavior

@brandonryan thanks for clarifying! Do you know if there's an open feature request for narrowing `key`? If so, please could you link it for me? Don't worry about it if...