Results 113 comments of Joe Clack

Related: #436 @aarontravass thoughts?

> we can add req.port The others could be added to the request prototype as get-properties, which would not incur any additional memory/processing costs unless accessed. Edit: the above would...

I'm referring to the options [here](https://nodejs.org/api/http.html#httpcreateserveroptions-requestlistener) which tinyhttp consumers cannot specify unless they invoke `createServer` themselves The way they are passed in is immaterial to me

> I am unsure if those options are truly required. If your point is 'we support it by allowing/instructing people to call `createServer` themselves', sure, I concede they are not...

> Can you add tests for the following cases: > > 1. `host` header is absent If the `Host` header is absent the request should always be aborted (400 Bad...

> How about tests checking if the host header is malformed? For example `Host: localhost:hello` or `Host: localhost` I agree those should be added to #92. Edit: Wouldn't `Host: localhost`...

> Your code introduces this check [...] and it would be better to write a case which covers this branch. That's a good point, well made > Shouldn't it return...

> What happens if the host header only contains `google.com` and the user logs `req.port`? `req.port` will be `undefined`, which is fine because either - the consumer can determine the...

I have set the `:authority` header tests to be skipped because the node.js Fetch API outright forbids assigning the `:authority` header manually, and I'm not sure how to work around...

> Maybe try `new Headers().set....` Already did, no dice