LongCatIsLooong

Results 102 comments of LongCatIsLooong

> > Unfortunately I can't think of a way to totally hide the recognizer thing or get rid of the displayString/linkString thing while also allowing users to be able to...

(It looks like there's an ongoing discussion here and on discord. Please let me know when the PR is ready to reland and I'll get the g3fix CL ready).

I don't have a Windows device to repro this, and looking at the code changes nothing stands out, I wonder if it could be the local const variable here? https://github.com/LongCatIsLooong/flutter/blob/8a0bb989345f5257e7ae77225ec0dd1b878418ec/packages/flutter/lib/src/material/tooltip.dart#L516-L523

@jonahwilliams do const variables get gc'ed when they're out of scope? I think I've seen a (potentially) similar regression: https://github.com/flutter/flutter/pull/126382

~Ok getting a cloudtop windows~ Update: still waiting for things to get approved. Hopefully the windows cloudtop will be ready on Monday.

I couldn't reproduce this on my cloudtop instance, using `dart bin/test_runner.dart test -t windows_home_scroll_perf__timeline_summary | grep gc_`. The 2 commit hashes I used: `#9da1d` and `#1b800`. results: `#9da1d` (before): ```...

Could you add the newline back at the end of text_field.dart? The analyzer is complaining (https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8790918503105134049/+/u/Analyze/analyze/test_stdout): > info • Missing a newline at the end of the file • packages/flutter/lib/src/material/text_field.dart:1465:46...

I think in #118568 the suggestion was that `style` should support `MaterialStateProperty`?

The tests are failing because: ``` error • Missing concrete implementation of 'TextInputFormatter.formatEditUpdate' • packages/flutter/test/services/text_formatter_test.dart:9:7 • non_abstract_class_inherits_abstract_member info • Specify type annotations • packages/flutter/test/services/text_formatter_test.dart:15:5 • always_specify_types info • Specify type...

That doesn't compile you can't instantiate an abstract class. Could you follow https://github.com/flutter/flutter/wiki/Running-and-writing-tests#running-unit-tests to run the test locally? If you run `flutter test` you'll see the errors immediately and that...