LongCatIsLooong

Results 102 comments of LongCatIsLooong

Sorry for the delayed reply. @JsouLiang looks like the `handleDelete` implementation in the pull request doesn't handle surrogate pairs or combining characters. The logic that handles that currently lives in...

https://flutter-gold.skia.org/search?issue=110218&crs=github&patchsets=9&corpus=flutter looks like the goldens contain the debug banner and whatnot. Consider using a repaint boundary to exclude those (that's what I meant in the review by "reduce the image...

Could you try syncing the branch to `HEAD`?

In case there're lazily built `FormField`s (e.g., in a lazy list) that haven't been built, calling `submit` would omit these fields. I think that is undesirable in a lot of...

Could you fix the error: ``` dartdoc:stdout: Generating docs for library widgets from package:flutter/widgets.dart... dartdoc:stderr: error: unresolved doc reference [FormState.submit] dartdoc:stderr: from widgets.FormField.submissionKey: (file:///tmp/flutter%20sdk/packages/flutter/lib/src/widgets/form.dart:375:17) dartdoc:stderr: in documentation inherited from widgets.FormField.submissionKey:...

After looking at https://gist.github.com/casvanluijtelaar/a6db35fb984cb41b1c99b45d7bf570bd .I think the API seems to be a bit limited to be used for JSON serialization: 1. it can only be used to construct flat dictionaries,...

I suspect this has to do with the fact the form is in a shadow DOM. @yjbanov is there a way to pull the form out of the `#shadow-root` thing?...

Changes LGTM. Are the tests supposed to pass without infra failures?

Is this implementing this feature? > A second force press leaves a selection anchor and then selects full words between the anchor and the current floating cursor position. I think...

Yeah good point. Nevertheless I think the method will still be useful for debugging despite the return value may not be stable. I added a paragraph to the documentation to...