Christoph Thiede

Results 128 comments of Christoph Thiede

> I'm not sure I want to know how you found this but thanks for raising the issue! :) I stumbled upon this during #163. :) > Is this blocking...

I just proposed a fix for Squeak Trunk, could you please confirm that it resolves the issue for you? :-) [[squeak-dev] Changeset: fix-generic-inspectOne-with-truncation.cs](http://forum.world.st/Changeset-fix-generic-inspectOne-with-truncation-cs-td5129694.html) The changeset will make its way into...

Great! Please feel free to merge the changeset into the Trunk if it looks good to you. :-)

Wait, why doesn't Travis CI run the contrib tests?

I am a bit confused that none of the travis logs contains the string `debug_environment`. Are the added tests actually run anywhere?

@Tarrasch Thanks for the review! `print_cmdline_on_failures` is not actually what this PR allows to change. It only allows to disable printing of environment variables. So what's about `print_environment_on_failures`? (But that's...

@Tarrasch Any updates on this? :-)

@Tarrasch Okay, would you agree with the name `print_environment_on_failures`? :)

@Tarrasch This PR has been ready for a long time and is only lacking properly naming. I would like to finally merge it, how would you like the parameter to...

Ah, thanks for the observation, @casperdcl! I realize that luigi evaluates the `run()` method entirely from the beginning until a not-yet-resolved dependency is met. So it is no wonder that...